Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Optional intermediary bridge netdev #1712

Merged
merged 5 commits into from
Nov 30, 2015

Conversation

awh
Copy link
Contributor

@awh awh commented Nov 23, 2015

Modify the weave script to interpose an intermediary bridge netdev between application containers and the OVS datapath. Fixes #1577.

@awh awh added this to the 1.4.0 milestone Nov 23, 2015
@awh
Copy link
Contributor Author

awh commented Nov 23, 2015

Hmmm need to think about plugin...

@awh
Copy link
Contributor Author

awh commented Nov 24, 2015

Tested the repro in #1577 against Scope 0.10.0 + this branch; as you can see short lived connections to port 80 are visible:
fastdatapath-conntrack
(note the spurious connection to port 4040 appears to be an instance of weaveworks/scope#520)

ip link del $BRIDGE_IFNAME >/dev/null 2>&1 || true
ip link add name $FASTDP_BRIDGE_IFNAME mtu $MTU type veth peer name $BRIDGE_IFNAME mtu $MTU || return 1

# Create intermediary bridge netdev

This comment was marked as abuse.

@awh awh force-pushed the issues/1577-interpose-bridge-netdev branch 3 times, most recently from 38d12e5 to d4a46ba Compare November 25, 2015 14:39
@awh awh self-assigned this Nov 25, 2015
@awh awh force-pushed the issues/1577-interpose-bridge-netdev branch from 14b53c4 to 890522f Compare November 25, 2015 16:31
@awh awh changed the title [WIP] Optional intermediary bridge netdev Optional intermediary bridge netdev Nov 25, 2015
@awh awh removed their assignment Nov 25, 2015
@bboreham bboreham self-assigned this Nov 30, 2015
@@ -108,6 +108,7 @@ exec_remote() {
-e WEAVE_CONTAINER_NAME \
-e WEAVE_MTU \
-e WEAVE_NO_FASTDP \
-e WEAVE_NO_BRIDGED_FASTDP \

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

@bboreham
Copy link
Contributor

Very nice.

@bboreham bboreham assigned awh and unassigned bboreham Nov 30, 2015
@awh awh assigned bboreham and unassigned awh Nov 30, 2015
bboreham added a commit that referenced this pull request Nov 30, 2015
Optional intermediary bridge netdev. Fixes #1577.
@bboreham bboreham merged commit a13351a into master Nov 30, 2015
@awh awh deleted the issues/1577-interpose-bridge-netdev branch December 16, 2015 13:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants